Matrix Games Forums

• RUS, Revolution under Siege
• ACW, American Civil War
• ROP, Rise of Prussia
• WIA, Wars in America
• NCP, Napoleon's Campaigns
• PON, Pride of Nations

• ongoing, active modding
• ongoing, active, diligent fixing of bugs en masse
• ongoing, active, useful, constructive player and modder feedback
• player activity
• forum activity
• closest proximity to bug-free "perfection"
• the AGElint developer's areas of personal player interest

• In the txt.y parser, reduce genericalness, increase specificity.
• Deepen and extend the txt.y parser, refining the syntax checks, but also adding semantic and logical checks.
• Integrate SelectFaction & SelectRegion into the semantic and logical checks.
• In the txt.y parser, add more CHKINT() checks.
• Better pinpoint the exact line number of reported error.
• Improve parser 'error' recovery, for detecting all errors etc. in a given data file.
• In names, more generally solve the problem of "foreign" (non-English, non-ASCII) characters.
• Generally solve the problem of files not ending in EOL (end-of-line, e.g., CR/LF).
• Present a pleasing display of blank lines for every possible combination of agelint command arguments.
• Better pinpoint the exact DB sources file of reported error.

• Add automated setting of agelintroot & gameroot in all scripts, not just the chk*.pl ones (by, for example, universal reference to agelint.conf).
• Check for duplication of UIDs/aliases.
• Check inter-regional linkages.
• Trim, or better categorize, reported "bad" aliases, localizations, graphics files, etc.

• Extend the 'make check' to encompass still more regression tests.
• Develop a functioning 'make install'.
• Add still more examples to the USAGE file.
• Host a web services site, where users can upload and check game data files without their having to install and run AGElint locally.
• Host on the web the Kwd (AGE keyword usage) database and support programs.
• In general, reduce false positives to a bare minimum.
• Fix bugs!

• In agelint.conf, added acwdir, ncpdir, pondir, ropdir, rusdir, wiadir.
• For agelint.conf, priority default location changed from /usr/local/etc to /usr/local/games/etc
• Added conf.pl, for agelint.conf processing by Perl scripts.
• In agelint.c, cleaned up agelintroot & gameroot code and logic.
• Fixed broken 'make check'.
• Substituted new, vetted test files in the CHK directory tree (and revised the squelches.chk.pl file).
• In agelint, chk*.pl, common.pl, cmd.[ly], etc., cleaned up command-line arguments, and fixed all Usage: statements.
• In chkaliases.pl, filtered out some false positives.
• In txt.[ly], fixed several bugs & false positives.
• Added grprpt.pl & rmgameroot scripts to distribution.
• Emptied FIX directory tree of useless junk files.
• Added USAGE, CHANGES & TODO files to distribution.
• Other minor code & doc fixes/changes.

ORIGINAL: Chliperic

Another possible false positive:

ChgUnitPoolInfos = $uni_DON_Amt1d;-999;75

The command accepts values from -999 to 999 for variation of force pool

<variation of Force Pool>

Integer (-999 to 999)

Changes the pool value by this amount

chgunitpoolinfos: _CHGUNITPOOLINFOS eq val sc intpos
                 | _CHGUNITPOOLINFOS eq val sc intpos sc intpos
                 {
                 /*                                                              
                 http://www.ageod.net/agewiki/ChgUnitPoolInfos                   
                 Syntax:  ChgUnitPoolInfos = <UnitDef>|<variation of Force Pool>|<AI Pool Ratio>       .                                                        
                 */
                 }
                 ;

 chgunitpoolinfos: _CHGUNITPOOLINFOS eq val sc int sc pct

                   _CHGUNITPOOLINFOS eq val sc intpos

• The AGE code had been extended to allow different alternative usages (in the ChgUnitPoolInfos example, allowing two arguments instead of three), and the AGEWiki docs had not been updated to reflect the extension.
• The AGEWiki doc is just flat out wrong; the actual usages are right.
• The AGE code recovers from the syntax errors gracefully, and defaults to some sensible behavior (in the ChgUnitPoolInfos, defaulting say to an assumed value of 100 (percent) for the missing third argument).
• The AGE 3.0 game, PON, might be extended to support alternative usages (but the AGEWiki was not yet edited to reflect that).
• Most peculiarly, when I saw usage exceptions in RUS -- there were more discovered in RUS than in any other game -- at the time I thought that the agreement with SEPRUS was that Pocus had farmed out the AGE coding to a SEPRUS programmer, thus that the RUS AGE engine code had forked from the mainline, standard AGEOD AGE (2.0) code.

When deciding the txt.y parser rules, I am guided primarily by the AGE Wiki documentation (where it exists, which is not always), and secondarily by actual usage as demonstrated by the game data files. They are not always in agreement! And there is much ambiguity and nuance. Bear that in mind when reviewing/critiquing the txt.y parser specification.

• The AGEWiki pages.
• Actual usage (across all games).
• Experienced dev/modder feedback (now possible, since I at least have your attention and active cooperation).
• Actual experimentation (don't just speculate; "look in the horse's mouth!") (but I really don't have time for it).

ORIGINAL: Chliperic

and 2 others:

ERROR: in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/Events/RUS All Scenarios.sct, at (or before) line 2287: syntax error: #|# (0x7c), #|#

in event evt_nam_Allied_involment_level:

2284 MaxDate = 1921/12/30
2285
2286 Actions
2287> PopUpText = str_nam_Allied_Involv_01|NULL|2|Allied_Involv_08|Event-img_Renforts_CMN_BlackSeaAllied|NULL
2288 EndEvent

This command accepts | rather than ; as the official tutorial files show it.

The second false positive is the lack of conditions in the evens in the scripts file (.ini): theses files serving for creating scenarios are made with events command without needing conditions).

Scripts/Script_T1.ini, Fri Oct 1 2010 11:26:12

WARNING: in /cygdrive/c/Revolution under Siege/Revolution Under Siege/RUS/Scripts/Script_T1.ini, at (or before) line 1130: no Conditions section

1127 Replacement = FIN;$famMilitia;3
1128 NULL = NULL
1129
1130> EndEvent

At present, AGElint is more than a beginning, but far from an ending. The dream is to code a vast set of utilities and capabilities to check all manner of AGEOD bugs/errors/glitches/anomalies. In agelint itself, beyond the syntax checking already in place, there are the beginnings of semantic and logic checking. Outside of agelint, there are many more QA checks we can apply to the AGE game data files.

#!/usr/bin/perl                                                                 
 
 $DEBUG = 0;
 
 $RUSDIR = "/media/KINGSTON/Games/AGEOD/Revolution under Siege FY/RUS";
 
 open(REGIONS, "$RUSDIR/Aliases/Regions.ini");
 while(<REGIONS>) {
     chomp;
     $line = $_;
     next if ($line =~ /^\s*#/);
     next if ($line =~ /^\s*\/\//);
     if ($line =~ /^\s*(\$[^=]+[a-zA-Z0-9])\s*=/) {
         $reglc = lc($1);
         print "#$reglc#\n" if $DEBUG;
         $regions{$reglc}++;
     }
 }
 close(REGIONS);

 open(FIND, "find \"$RUSDIR\" -exec egrep \"SelectRegion\" {} \\; \| awk -F= '{print \$2}' \| sort \| uniq |");
 while(<FIND>) {
     chomp;
     print "line #$_#\n" if $DEBUG;
     next unless (/^\s*(\$[-\. a-zA-Z0-9]*[a-zA-Z0-9])/);
     $reg = $1;
     $reglc = lc($reg);
     print "reg  #$reglc#\n" if $DEBUG;
     next if ($reglc =~ /(playboard)/);
     if (! $regions{$reglc}) {
 	print "$reg not found\n";
     }
 }
 close(FIND);
 
 exit 0;

There's still much more untapped potential, much more to be done...

[root@telemann agelint]# ./chkSelectRegion.pl 2>&1 | sort | uniq
$Almetevsk not found
$Baltic Channel not found
$Bay of Samsun not found
$Black Sea not found
$Cape Civa not found
$Cape Ince not found
$Fergana not found
$FRA not found
$Gulf of Trapezus not found
$Hoburgen not found
$Huiliaipole not found
$Kalmar Sund not found
$Keuruu not found
$North Baltic Sea not found
$Osel not found
$Ost See not found
$Rustavi not found
$Savo not found
$Shchuche Ozero not found
$South Baltic Sea not found
$Southeastern Black Sea not found
$SouthWestern Black Sea not found
$Swedish Channel not found
$Verkhovie not found

ORIGINAL: Chliperic

Don't forget FY is for now only the modding of the Grand Campaign. This one doesn't use all the files of RUS;

For example, I've noticed Drang Nach Osten files have a lot of errors. However, as There aren't used in FY, I haven't fixed them. Yet. [:D] So these mispelled aliases in files may result of event files unused in the FY Grand Campaign, which by the contrary, is now 99.99% error free ( I'm yet inspecting 2 reports which may be false positive).

ORIGINAL: berto

When first coding txt.y, whenever I saw many usage counterexamples (where "many" is loosely defined), I inferred that the counterexamples might be acceptable alternative usages. It could be that

• The AGEWiki doc is just flat out wrong; the actual usages are right.

...

In the AGElint README file, I write:

When deciding the txt.y parser rules, I am guided primarily by the AGE Wiki documentation (where it exists, which is not always), and secondarily by actual usage as demonstrated by the game data files. They are not always in agreement! And there is much ambiguity and nuance. Bear that in mind when reviewing/critiquing the txt.y parser specification.

Going forward, and as I review and refine the txt.y parser, I will have to base "truth" on

• The AGEWiki pages.
• Actual usage (across all games).
• Experienced dev/modder feedback (now possible, since I at least have your attention and active cooperation).
• Actual experimentation (don't just speculate; "look in the horse's mouth!") (but I really don't have time for it).

in that order of authority.

chgpopeducation: _CHGPOPEDUCATION eq intpos
                 {
                 /*                                                              
                 http://www.ageod.net/agewiki/ChgPopEducation                    
                 Syntax:  ChgPopEducation = Value  Or  ChgPopEducationEx = Servile|Peasant|Worker|Middle|Upper|Aristocrat                                       
                 */
                 }
                 ;

chgpopeducationex: _CHGPOPEDUCATIONEX eq int sc int sc int sc int sc int sc int all
                 { CHKINT( $3, -999, -999, 999, 999);
                   CHKINT( $5, -999, -999, 999, 999);
                   CHKINT( $7, -999, -999, 999, 999);
                   CHKINT( $9, -999, -999, 999, 999);
                   CHKINT($11, -999, -999, 999, 999);
                   CHKINT($13, -999, -999, 999, 999);
                 /*                                                              
                 http://www.ageod.net/agewiki/ChgPopEducation                    
                 Syntax:  ChgPopEducation = Value  Or  ChgPopEducationEx = Servile|Peasant|Worker|Middle|Upper|Aristocrat                                       
                                                                                 
                 documented | but ; in actual usage                              
                 the appended 'all' is undocumented but conforms to actual usage  
                 */
                 }
                 ;

 all:              /* empty, no problem */
                 | sc _ALL
                 ;