Page 1 of 1

Yamato and Mushashi

Posted: Wed Nov 17, 2021 9:18 pm
by generalfdog
Japans 2 super battleships Yamato and Mushashi both have a strength of but Mushashis is 5/4 so once it is damaged it can't ever be a super battleship again is this intentional or a mistake?

RE: Yamato and Mushashi

Posted: Wed Nov 17, 2021 9:50 pm
by ncc1701e
Surely a mistake, it should be 5/5.

RE: Yamato and Mushashi

Posted: Wed Nov 17, 2021 9:54 pm
by ncc1701e
Yep doing a quick check, this is a bug.

Image

RE: Yamato and Mushashi

Posted: Thu Nov 18, 2021 1:36 pm
by AlvaroSousa
The repair amount is based on the maxStrength value of the unit itself. So I think you have an older scenario prior to me fixing this issue.

I looked at all the scenarios and the Musashi is a 5/5

CODE LINE

healthRepairAmount = Math.Min(healthRepairAmount, maxHealth - health);


maxHealth is assigned to all naval units individually.

RE: Yamato and Mushashi

Posted: Thu Nov 18, 2021 4:38 pm
by ncc1701e
Above screenshot was taken with Beta 5.4, this is Pacific 1942 scenario.

RE: Yamato and Mushashi

Posted: Fri Nov 19, 2021 12:56 pm
by AlvaroSousa
fixed.

RE: Yamato and Mushashi

Posted: Sat Nov 20, 2021 5:46 am
by ncc1701e
Looks good now, thank you.

Image