Page 1 of 1

[1.09.07] Typo in Annexation card logic means minor's protector REGIMEKEY isn't set to 0 on failure

Posted: Thu Dec 09, 2021 7:42 pm
by Catasteroid
In SE_Diplomatic table 216 Flex Diplomatic Action FX vs AI there is a typo in the logic on row 255 where the SET Logic in column 2 reads "TARGETREGKEY.master=0;TARGETREKEY.protector=0; exe(346,2,SOURCEREGIMESLOT,TARGETREGIMESLOT);" and the second statement has "TARGETREKEY" instead of "TARGETREGKEY" so it should be "TARGETREGKEY.master=0;TARGETREGKEY.protector=0; exe(346,2,SOURCEREGIMESLOT,TARGETREGIMESLOT);". I imagine this is probably the case in the most recent beta versions too.

The result of this bug is that while you will be placed in a state of war if you played the card on a protectorate of yours it will remain your protectorate which might result in unintended, weird behaviour. While it declares war via an exec function, if that's the same function used in the popup interface opened when you try to move a unit into their territory it'll count as declaring war and invading a protectorate of yours which adds a harsh modifier to happiness/loyalty/prestige damage.

Re: [1.09.07] Typo in Annexation card logic means minor's protector REGIMEKEY isn't set to 0 on failure

Posted: Mon Dec 26, 2022 12:01 pm
by Magirot
This is still the case in v1.12m.

Re: [1.09.07] Typo in Annexation card logic means minor's protector REGIMEKEY isn't set to 0 on failure

Posted: Tue Jan 03, 2023 9:23 am
by Vic
Now that is an excellent bug report. Up to the exact code change I should make. Big thanks! will be fixed next version

Really a shame it passed under my radar in 2021. Apologies