Editor: Unit renaming bug

[DarkHorse2]

ISSUE

Changing the unit name via the Editor's unit properties dialog box can result in the deletion of the original unit name and a duplication of the new name in the \text\EN\unit.txt file.

SC3_UnitPropertiesDialog.jpg (65.12 KiB) Viewed 134 times

The following is an example of the covert changes made to the \text\EN\unit.txt file after I had:
1. Deleted the BB named "Conte di Cavour";
2. Changed the BB named "Andrea Doria" from "Andrea Doria" -> "Conte di Cavour";

As shown below, unexpectedly this change modified the BB's unit names list, by duplicating "Conte di Cavour" and removing "Andrea Doria" entirely.

Just because I change a unit name on the map does NOT mean I am done with that name and wish it removed!

In fact, I expect the name to continue to exist until I explicitly remove it from the unit's name list.

GC3_unit_txt_snippet.jpg (77.04 KiB) Viewed 134 times

[Hubert Cater]

The Editor tries to keep the unit.txt file down to a minimum and only keep names that are in use in game, e.g. either on the map or in the build lists... this is more for our end as we need to translate (when we are done and keep costs down) and keep unused names to a minimum as a result.

But there may be a few quirks in the process for sure when you do stuff like you did in the Editor that we might not normally do etc

[DarkHorse2]

It would have been better had I just deleted the two units and added a new one, using the intended name.

I did not realize that the editor handles those two mechanisms differently.

When you delete a unit from the map, it does not remove the name from the unit's name list.

(let me check this to make sure I am not recalling incorrectly....)

1. going to delete the 3rd Gebirgsjäger Mountain Division.

---

SC3_3rdMnt_BeforeDeletion.jpg (220.16 KiB) Viewed 116 times

2. this is after the 3rd Gebirgsjäger Mountain Division has been deleted.

---

SC3_3rdMnt_AfterDeletion.jpg (98.29 KiB) Viewed 116 times

3. Going to save the scenario and reload....

4. No change to the Text\EN\Unit.txt or change to the German Mountain Division name list.

(this is how I would expect it to work)

HOWEVER, if I change the name in the unit's property dialog box it works differently? Who is going to know or expect this?

The name's should not be covertly removed unless explicitly down via the unit's name list.