[FIXED] 1278.1 - cloning duplicates manually added comms and removes manually added radars

[laro]

Hi,

When I try to clone facility type units (in scenario editor with shift+c) with manually added comms /datalinks and radars then datalinks get duplicated and manually added radars get removed.

Modified units are on the left / west and cloned units on the right / east.

SkyCeptor battery has 3 extra Aster Datalinks and Patriot looses GhostEye secondary array radars.

Would you be so nice and look into it?

[michaelm75au]

I'll check it out

[laro]

Thanks.

There is an additional problem with cloning which I did not mention in my original post.

When you remove a radar from a facility and put a new one in, after cloning the original one will be added back. Unfortunately I did not add it into my example scenario, but AFAIR it still happens with 1278.1. It can be easily recreated though. If you can't replicate it I can add the scenario where it happened.

This broke in this or in the previous release, before that it was OK (I think it is OK in the current Steam beta, which is i believe 1276.1?).

[michaelm75au]

Cloning is getting harder.
What happens it that it takes a copy from the database, and then applies the 'delta' changes to it of the cloned unit.
Basically the 'delta' created is same as the one for the INI. So, if it is wrong, it probably means it will have issues when trying to update using the INI file.
May be a few days before I can delve into it as bit busy.

[michaelm75au]

For the Ghosteye. the unit from database has a main and 2 secondary radars. Did you remove them and then add them back???
Cloning the database unit works as expected. Just trying to understand the steps you took.

I noticed applying the SBR script to the Patriots, it adds a new Primary each time I run it. Which is weird as there are no instructions in the INI to add or remove sensors.

Will deep dive on the weekend.

[michaelm75au]

Mmmm. I can see the issue. The Ghosteyes are in vehicles, which are being removed for the cloned unit.
The problem seems to be that it is seeing your manually added radar as belonging to the ' radar vehicle' being deleted.

Will take some time to work thru this.

[michaelm75au]

Fixed for next build.

[laro]

Thanks for solving this and sorry for the late reply.

I was doing exactly what you described except removing the vehicle I think. I just removed 2 secondary radars.

The reason they were removed is described here:
https://www.matrixgames.com/forums/view ... 2#p5035542

The problem from the above posts occurred after I submitted DB update ticket (all arrays on GhostEye were facing the same direction). This was fixed in by adding secondary vehicle:
https://github.com/PygmalionOfCyprus/cm ... ssues/2035

I also noticed today that these added secondary radars can't detect and track targets (I only checked against ballistic targets aiming at the SAM). Primary array works OK. So maybe there is more things broken due to cloning. It may be as well a DB issue or sensor add issue though.