Error with CheckActionCard

[Iron Knight]

I keep getting errors on lines 22, 31, 49, 58, 67, 77, 87, 96, 105, 114, 123, 132, 141, 151, 160, 169, and 178 (all CheckActionCard's ). Any idea why? I don't get errors on 4, 13, or 40 (Also CheckActionCard's), which just confuses me more. [&o] Any help would be greatly appreciated! (especially considering the time I've put into this matrix [X(], man I must be crazy)

0) CHECK: Gameslot_Diplomacy(#0) == 1
1) CHECK: CheckPeace(0, 1) == 0
2) CHECK: The Valkarian Empire_Peace Offered to SK(#1) == 0
3) CHECK: Sevensgrad Kingdom_Peace Offered to VE(#0) == 0
4) CHECK: CheckActionCard(0, 0) == 0
5) EXECUTE: ExecGiveActionCard(0, 0)
6) END CHECK
7) END CHECK
8) END CHECK
9) END CHECK
10) CHECK: CheckPeace(0, 2) == 0
11) CHECK: The Valkarian Empire_Peace Offered to KO(#2) == 0
12) CHECK: Kitterarch Order_Peace Offered to VE(#0) == 0
13) CHECK: CheckActionCard(3, 0) == 0
14) EXECUTE: ExecGiveActionCard(3, 0)
15) END CHECK
16) END CHECK
17) END CHECK
18) END CHECK
19) CHECK: CheckPeace(0, 3) == 0
20) CHECK: The Valkarian Empire_Peace Offered to WS(#3) == 0
21) CHECK: Wittenburg State_Peace Offered to VE(#0) == 0
22) CHECK: CheckActionCard(6, 0) == 0
23) EXECUTE: ExecGiveActionCard(6, 0)
24) END CHECK
25) END CHECK
26) END CHECK
27) END CHECK
28) CHECK: CheckPeace(0, 4) == 0
29) CHECK: The Valkarian Empire_Peace Offered to KC(#4) == 0
30) CHECK: Kharic Confederacy_Peace Offered to VE(#0) == 0
31) CHECK: CheckActionCard(9, 0) == 0
32) EXECUTE: ExecGiveActionCard(9, 0)
33) END CHECK
34) END CHECK
35) END CHECK
36) END CHECK
37) CHECK: CheckPeace(1, 0) == 0
38) CHECK: Sevensgrad Kingdom_Peace Offered to VE(#0) == 0
39) CHECK: The Valkarian Empire_Peace Offered to SK(#1) == 0
40) CHECK: CheckActionCard(12, 1) == 0
41) EXECUTE: ExecGiveActionCard(12, 1)
42) END CHECK
43) END CHECK
44) END CHECK
45) END CHECK
46) CHECK: CheckPeace(1, 2) == 0
47) CHECK: Sevensgrad Kingdom_Peace Offered to KO(#2) == 0
48) CHECK: Kitterarch Order_Peace Offered to SK(#1) == 0
49) CHECK: CheckActionCard(15, 1) == 0
50) EXECUTE: ExecGiveActionCard(15, 1)
51) END CHECK
52) END CHECK
53) END CHECK
54) END CHECK
55) CHECK: CheckPeace(1, 3) == 0
56) CHECK: Sevensgrad Kingdom_Peace Offered to WS(#3) == 0
57) CHECK: Wittenburg State_Peace Offered to SK(#1) == 0
58) CHECK: CheckActionCard(18, 1) == 0
59) EXECUTE: ExecGiveActionCard(18, 1)
60) END CHECK
61) END CHECK
62) END CHECK
63) END CHECK
64) CHECK: CheckPeace(1, 4) == 0
65) CHECK: Sevensgrad Kingdom_Peace Offered to KC(#4) == 0
66) CHECK: Kharic Confederacy_Peace Offered to SK(#1) == 0
67) CHECK: CheckActionCard(21, 1) == 0
68) EXECUTE: ExecGiveActionCard(21, 1)
69) END CHECK
70) END CHECK
71) END CHECK
72) END CHECK
73) EMPTY
74) CHECK: CheckPeace(2, 0) == 0
75) CHECK: Kitterarch Order_Peace Offered to VE(#0) == 0
76) CHECK: The Valkarian Empire_Peace Offered to KO(#2) == 0
77) CHECK: CheckActionCard(24, 2) == 0
78) EXECUTE: ExecGiveActionCard(24, 2)
79) END CHECK
80) END CHECK
81) END CHECK
82) END CHECK
83) EMPTY
84) CHECK: CheckPeace(2, 1) == 0
85) CHECK: Kitterarch Order_Peace Offered to SK(#1) == 0
86) CHECK: Sevensgrad Kingdom_Peace Offered to KO(#2) == 0
87) CHECK: CheckActionCard(27, 2) == 0
88) EXECUTE: ExecGiveActionCard(27, 2)
89) END CHECK
90) END CHECK
91) END CHECK
92) END CHECK
93) CHECK: CheckPeace(2, 3) == 0
94) CHECK: Kitterarch Order_Peace Offered to WS(#3) == 0
95) CHECK: Wittenburg State_Peace Offered to KO(#2) == 0
96) CHECK: CheckActionCard(30, 2) == 0
97) EXECUTE: ExecGiveActionCard(30, 2)
98) END CHECK
99) END CHECK
100) END CHECK
101) END CHECK
102) CHECK: CheckPeace(2, 4) == 0
103) CHECK: Kitterarch Order_Peace Offered to KC(#4) == 0
104) CHECK: Kharic Confederacy_Peace Offered to KO(#2) == 0
105) CHECK: CheckActionCard(33, 2) == 0
106) EXECUTE: ExecGiveActionCard(33, 2)
107) END CHECK
108) END CHECK
109) END CHECK
110) END CHECK
111) CHECK: CheckPeace(3, 0) == 0
112) CHECK: Wittenburg State_Peace Offered to VE(#0) == 0
113) CHECK: The Valkarian Empire_Peace Offered to WS(#3) == 0
114) CHECK: CheckActionCard(36, 3) == 0
115) EXECUTE: ExecGiveActionCard(36, 3)
116) END CHECK
117) END CHECK
118) END CHECK
119) END CHECK
120) CHECK: CheckPeace(3, 1) == 0
121) CHECK: Wittenburg State_Peace Offered to SK(#1) == 0
122) CHECK: Sevensgrad Kingdom_Peace Offered to WS(#3) == 0
123) CHECK: CheckActionCard(39, 3) == 0
124) EXECUTE: ExecGiveActionCard(39, 3)
125) END CHECK
126) END CHECK
127) END CHECK
128) END CHECK
129) CHECK: CheckPeace(3, 2) == 0
130) CHECK: Wittenburg State_Peace Offered to KO(#2) == 0
131) CHECK: Kitterarch Order_Peace Offered to WS(#3) == 0
132) CHECK: CheckActionCard(42, 3) == 0
133) EXECUTE: ExecGiveActionCard(42, 3)
134) END CHECK
135) END CHECK
136) END CHECK
137) END CHECK
138) CHECK: CheckPeace(3, 4) == 0
139) CHECK: Wittenburg State_Peace Offered to KC(#4) == 0
140) CHECK: Kharic Confederacy_Peace Offered to WS(#3) == 0
141) CHECK: CheckActionCard(45, 3) == 0
142) EXECUTE: ExecGiveActionCard(45, 3)
143) END CHECK
144) END CHECK
145) END CHECK
146) END CHECK
147) EMPTY
148) CHECK: CheckPeace(4, 0) == 0
149) CHECK: Kharic Confederacy_Peace Offered to VE(#0) == 0
150) CHECK: The Valkarian Empire_Peace Offered to KC(#4) == 0
151) CHECK: CheckActionCard(48, 4) == 0
152) EXECUTE: ExecGiveActionCard(48, 4)
153) END CHECK
154) END CHECK
155) END CHECK
156) END CHECK
157) CHECK: CheckPeace(4, 1) == 0
158) CHECK: Kharic Confederacy_Peace Offered to SK(#1) == 0
159) CHECK: Sevensgrad Kingdom_Peace Offered to KC(#4) == 0
160) CHECK: CheckActionCard(51, 4) == 0
161) EXECUTE: ExecGiveActionCard(51, 4)
162) END CHECK
163) END CHECK
164) END CHECK
165) END CHECK
166) CHECK: CheckPeace(4, 2) == 0
167) CHECK: Kharic Confederacy_Peace Offered to KO(#2) == 0
168) CHECK: Kitterarch Order_Peace Offered to KC(#4) == 0
169) CHECK: CheckActionCard(54, 4) == 0
170) EXECUTE: ExecGiveActionCard(54, 4)
171) END CHECK
172) END CHECK
173) END CHECK
174) END CHECK
175) CHECK: CheckPeace(4, 3) == 0
176) CHECK: Kharic Confederacy_Peace Offered to WS(#3) == 0
177) CHECK: Wittenburg State_Peace Offered to KC(#4) == 0
178) CHECK: CheckActionCard(57, 4) == 0
179) EXECUTE: ExecGiveActionCard(57, 4)
180) END CHECK
181) END CHECK
182) END CHECK
183) END CHECK
184) END CHECK

[zook08]

The only thing I can think of is that the Regime# or Action card# doesn't exist. Maybe you deleted them?

[Iron Knight]

No, they are all there. They showed up right be for I put in the Checks, but I needed the check because multiple copies of a card were showing up. Is that normal?

[Vic]

mail me the files to vic@xs4all.nl and i can have a look for you.

[zook08]

Got it:

13) CHECK: CheckActionCard(3, 0) == 0
14) EXECUTE: ExecGiveActionCard(3, 0)

The parameters (regime, card) are in different orders in those commands. I've had the same problem, it's a bit annoying.

[tweber]

I have never used 'checkactioncard'.  For cards like this, It is just easier to clear all hands with a loopr -
 
loop through the regimes
loop through the cards
remove the cards
 
Then, add them back in if your conditions are met.  This would take out about 40 lines in the above. 
 
Also, you have some redundant blocks of checks.  See lines 176/177 and 139/138 for instance.  You could give out the cards in either situation reducing the number of blocks you need from n*(n-1) for n regimes to n-1+n-2+n-3+...  (works out to 12 vs 20 in this case).  This would also reduce your code length. 
 
Finally, you could might be able shorten the code depending on the action card given. 

[Iron Knight]

Thanks Zook! [&o]

Ya, my professor would call it the "brute force" approach, way too much work than is needed. I'll definitely change the way I did it this time to something more like ED's system for the next one.