Removing extra warnings

[Jimmer]

Please let me know if you think this rises to the level of having a Mantis ticket opened on it:

When you own free states and buy troops during econ, the system prompts you as to whether you want to buy corps counters. The game does this even if all counters available to that nation are already on the map.

I think it should check to see if there are any counters available for purchase just prior to giving the warning.

Example: I buy 3 infantry on the first econ phase of the game (as France). I get a warning when I end the phase asking if I want to buy a corps counter for Holland. However, the one and only corps counter is already on the map.

NOTE: The root code here is very good: Warning you about having factors that might require a corps counter. It just doesn't understand when to quit.

[pzgndr]

I agree.  If there are no counters to buy, then don't ask me.  The warning becomes annoying and stops being helpful.  Since infantry and militia can usually be placed somewhere in a garrison, there's no need to ask about counters for those.  (Maybe offer an option to Don't Ask Me Again?)  For specialized units like cavalry and guards and artillery, sure, remind me if there are no counters on the map or all the current counters are full. 

[MarshallEllis]

The infantry / militia option to garrisons is not always a safe assumption. I will look at refining the warning a bit.
It's still better than forgetting and losing factors!
 

[Jimmer]

Oh, I definitely agree with that.
 
I would think a minor fix would be to check for the presence of available corps counters, right after (or before) you enter the routine to send the dialog. If there are NO available counters, then skip the message.
 
Optionally, on top of that, you could check for there being no RELEVANT counters. For example, if nothing but guard are coming, and there are no corps available for guard factors ...
 
However, I can live with it as it is for the majors. It's the notice coming up for EVERY minor, when none of them have available corps; THAT is what bothers me.

[easterner]

Warning me to buy corps when none to buy: Annoying
 
Warning me to buy corps when nation is Oldenburg: Ridiculous
 
Corpless nations defintely need be  re-removed from minors list.