Odd seige situation

[ravenflight]

Hi All,

I did a naval invasion of South Pomerania with 1 Swedish Corps. The territory around it was owned by Prussia, but South Pomerania was owned by France, who I am at war with. South Pomerania was unoccupied.

I landed with invasion supply no problem, and occupied the city.

That turn France besieged me. Again, no problem.

The next turn I built a depot, which my understanding from playing the board game (maybe wrong, but if right, the coding is incorrect), which, since I was being besieged would be built in the port-city and I would have supply.

I then suddenly was outside the city, one of the two French corps were IN the city, and I faced a field battle!

It was all very odd.

Thought?

[DCWhitworth]

Bug. The game has long had issues with working out who controls what in slightly obscure situations. It seems to have especial difficulty with the situation above where you are besieged in a city that is in enemy territory. Very disappointed this hasn't been fixed yet.

[pzgndr]

I found a unit_swap_city_location function that is called when an original owner is besieging one of his occupied cities and the battle is inconclusive. The code is then swapping units "so that the engine realizes the invaders are still owning the city"? This does not make sense to me. There may well still be some ownership bug that this was trying to fix, but physically swapping the units inside of a besieged city with those outside isn't right. For v1.21.04 I am commenting out the two places in the code where this is happening so maybe the mystery unit swapping will stop. If there is still an ownership bug then I will deal with that.

[ravenflight]

Good work Bill