Refit bugs(?)

[Bozo_the_Clown]

No, it's not working correctly. It's a simple test. Start a new campaign game and put a weak German unit (for example a garrison unit) on refit, proceed to next turn, check value. Reload the game, put unit on ready, proceed to next turn, check value. Reload the game, put unit on reserve, proceed to next turn, check value.

The unit on reserve should get the 25% penalty not the unit on refit.

[morvael]

I think construction penalty to units treated permanently as refitting is indeed a bug.
And function checking for reserve status is also bugged, checking refit status instead.
Something to fix later today.

[eskuche]

Thanks morvael. I noticed this while playing the SU for the first time and it imbalances the game towards Germans IMHO because you’re caught in situation where it’s hard to justify ever refitting. Cheers

[Bozo_the_Clown]

I think construction penalty to units treated permanently as refitting is indeed a bug.
And function checking for reserve status is also bugged, checking refit status instead.
Something to fix later today.

Great, thanks for fixing it. This is one of those bugs that would prevent me from starting a new game.

[eskuche]

I can delete the thread if you’re really itching for a game

[morvael]

7. Fixed a bug where penalty for being on refit to construction value was applied to units treated as being on refit permanently.
8. Fixed a bug where penalty for being in reserve to construction, engineer, and artillery value was applied to combat units (and support units attached to them) on refit.

[eskuche]

Wait, so construction battalions and sapper regiments were in fact being penalized?

Not having played in the era of overpowered sapper regiments I was surprised people were making such a fuss over a 10 construction SU

[morvael]

ORIGINAL: eskuche
Wait, so construction battalions and sapper regiments were in fact being penalized?

[:(] yes

[joelmar]

nice catch eskuche, well done!

Thanks Morvael for the quick fix