friendly/enemy bug

[pdzun]

Hi

I'm putting here bugs which were observed multiple times in different games but I think have common source (I might be wrong) - the game puts both friendly and enemy units in friendly category in display window (showing units in selected area) - making siege or battle not possible.

example 1 - russian is in war with france - trying to besiege fr garrison in Magdeburg (currently fr ceded) - but are shown as allied to france

russia_france_garrison_bug.sav.zip

(325.82 KiB) Downloaded 9 times

example 2 - GB human player with naples corps unable to battle turkey corps (naples is GB controlled because of turkey dow). In turkish ai land phase battle is executed

russia_france_garrison_bug.sav.zip

(325.82 KiB) Downloaded 9 times

example 3 - saxony controlled by PR human player not able to besiege FR AI hannover

land_pr_fra_sax_allies_bug.sav.zip

(208.17 KiB) Downloaded 4 times

once similar case made game stuck - game moved human pr corps to city from area - after FR enemy corps entered, but exceeded city capacity and was demendaning to remove forces from city in next reinf phase of GB human player turn (which was not possible) and refused to proceed to next turn (unfortunatelly no savegame for this case)

br
Piotr

[pzgndr]

Alright, for #1, I was able to undo the Russian moves and then move them back in to see what was happening.
- fixed movetocityExecute to check area control (e.g., France, at war), not area nation (e.g., Prussia, not at war)
So now, the Russians are able to besiege Magdeburg.

For #2 and #3, I suspect something similar is going on but I need the land move game save to see what is happening, not the after-the-fact land combat that isn't working. I think the sieges may be fixed but for the rural combats with issues I need to see where in the code the units are being placed in the same sub_location as enemy, thus no combat. We'll get there.