Garrisoned, Allied port, not protecting allied fleets

[bresh]

In one of the pbm games im in.
GB port attacked a French-controlled and garrisoned, Kiel, Russia had put some fleets there for protection.(yes Fr is at war with GB to)

There was no port defense. (created a test.game and confirmed this).

I will send you test files.

Also as you can see, if 16 fleets are involved, only 15 show for casulties.

Regards
Bresh

[MarshallEllis]

Got your email and will look at!
Sent your game back to you with your changes done!

[bresh]

ORIGINAL: Marshall Ellis

Got your email and will look at!
Sent your game back to you with your changes done!

Hi Marshall, thanks for fixing the gamesave.

I did some further testing, was hoping the port would defend the fleet, if the port-owner was in control of the lend fleet.

Sadly it seems garrisoned-allied port does not defend allied fleets, against common enemy, even when the ally has control of the fleet.

Any ideas of how we solve this ?
Hope you can fix this soon, players are suggesting putting game on hold for a fix !

Results of my tests
Ru&Fr allied, both at war with GB, port is French controlled.

Port-garrison French, Russian fleet lend to France: no port defense
Port-garrison French&Russian :no port defense.
Port-garrison solely Russian :Port defense.


Regards
Bresh

[MarshallEllis]

Bresh:

I'm not sure how to solve this if the ally is not at war??? May need to force a DOW from the port attacker??? I dunno...
Any thoughts?

[ndrose]

If the ally is not at war, they cannot fire the port guns, so there's no need to worry about that. But I think Bresh is saying that here the ally *is* at war, in which case this is a bug.

[bresh]

ORIGINAL: Marshall Ellis

Bresh:

I'm not sure how to solve this if the ally is not at war??? May need to force a DOW from the port attacker??? I dunno...
Any thoughts?

Marshall, im not sure I understand your question ?
I did not test the situation where the port-owner is not at war with the attacker.
Technically, you can not blockade a port of a nation you are not at war with, so you should not be able to port attack eighter, i dont know how game should behave if the port-owner gave access to both.

But its essential that the port-owner, uses port defense against common enemies.

Like i wrote, to quote myself.

ORIGINAL: Bresh
Results of my tests
Ru&Fr allied, both at war with GB, port is French controlled.

Port-garrison French, Russian fleet lend to France: no port defense
Port-garrison French&Russian :no port defense.
Port-garrison solely Russian :Port defense.

The previous send files, only tested if France defended, Russian fleet against GB-port attack. Witch it turned out they did not.
And yes, both Fr&Ru where also then at war with GB.

This is a one of those bigger bugs, that sadly requires action, like editing savegame(more work for you). And the only present workaround atm, seems to be some bad, redistributing of garrisons. Till a fix is about, the sooner the better..

It seems, the code is eighter not checking when to use port defense propper, or has a bug in the code.


Regards
Bresh

[MarshallEllis]

WOOOPS! I see now what you're saying and totally agree! My bad!
Is this in Mantis with a save?

[bresh]

ORIGINAL: Marshall Ellis

WOOOPS! I see now what you're saying and totally agree! My bad!
Is this in Mantis with a save?

Hi Marshall.
Sorry no, im not on Mantis, im solely using matrix-forum.

But it should not be hard to reproduce, testing shows the only times port defense works, is when owner of fleet equals owner of sole-garrison.
So you will need to check the coding, since against mutual enemies, allies are supposed to work together...


Regards
Bresh

[kirk23_MatrixForum]

Hi Bresh, I agree this is a major problem, if any country is allied with another,then the port defences must be able to protect any fleets that are in port[:o]

[MarshallEllis]

ORIGINAL: bresh

ORIGINAL: Marshall Ellis

WOOOPS! I see now what you're saying and totally agree! My bad!
Is this in Mantis with a save?

Hi Marshall.
Sorry no, im not on Mantis, im solely using matrix-forum.

But it should not be hard to reproduce, testing shows the only times port defense works, is when owner of fleet equals owner of sole-garrison.
So you will need to check the coding, since against mutual enemies, allies are supposed to work together...


Regards
Bresh

If you run across a save that I can use to code against, it sure would save me a lot of time!

[bresh]

ORIGINAL: Marshall Ellis

ORIGINAL: bresh

ORIGINAL: Marshall Ellis

WOOOPS! I see now what you're saying and totally agree! My bad!
Is this in Mantis with a save?

Hi Marshall.
Sorry no, im not on Mantis, im solely using matrix-forum.

But it should not be hard to reproduce, testing shows the only times port defense works, is when owner of fleet equals owner of sole-garrison.
So you will need to check the coding, since against mutual enemies, allies are supposed to work together...


Regards
Bresh

If you run across a save that I can use to code against, it sure would save me a lot of time!

Well i did send you the savegame to fix(i did also attach, a testgame)
In the test.game(a normal testgame, no pbm since its in the general code).
Ru+Fr.allied & both war with GB, At Corsica Port & Garrison where French fleet, was Russian.
Should give you some idea, if you debug the code while running the naval-battle.savegame)

I

Regards
Bresh

[MarshallEllis]

Bresh:

Can you tell me when you sent it? I've got so many emails with games that I need to narrow the search a bit!

[bresh]

ORIGINAL: Marshall Ellis

Bresh:

Can you tell me when you sent it? I've got so many emails with games that I need to narrow the search a bit!

Email with the previous testgame resend.
Subject:[EIANW] Bug, allied port defense not working.(Testgame Resend)

Hope you can use this to help debug.

Regards
Bresh

[MarshallEllis]

Thanks!

[bresh]

ORIGINAL: Marshall Ellis

Thanks!

Marshall, any chance looking into this ?
Im thinking if conditons(flags) are set propper, you might even be able to get garrisoning-Corps to work the port-defense.(witch acording to manual they dont,[havent tested]).

Who controls the fleet inside, or who controls the garrison should not important, if both are enemies with the port-attacker.

I think the conditions you need to check, is.
Who controls the port, is he enemy with the port-attacker ? Remember a MP cant force a neutral-port to use the port defense.
Who garrisons the port, is he enemy with the port-attacker ? Remember to check all garrisons.
So if both get value true, then trigger the port-defense.

Atm it seems your condition checks if garrison and fleet are owned by same nation.(since lending fleet to port-garrison owner doesnt trigger, or having a combined garrison).

Regards
Bresh

[MarshallEllis]

I fixed this in the last 1.08 build so that allied ports will defend now.
 

[bresh]

ORIGINAL: Marshall Ellis

I fixed this in the last 1.08 build so that allied ports will defend now.

Great !

Another good step !

Regards
Bresh