Aborted cvp's aren't aborting

[joshuamnave]

Two CVP's were used for ground support and intercepted. During the air to air battle, one was aborted. The German fighter was also aborted, causing Germany to abort the fight rather than risk 2 bombers unescorted against a CW fighter that was escorting the CVP's. However, both CVP's added their factors as ground support, despite one of them aborting.

[AxelNL]

ORIGINAL: Zartacla

Two CVP's were used for ground support and intercepted. During the air to air battle, one was aborted. The German fighter was also aborted, causing Germany to abort the fight rather than risk 2 bombers unescorted against a CW fighter that was escorting the CVP's. However, both CVP's added their factors as ground support, despite one of them aborting.

This area of the code has more problems with aborts of bombers which should not happen. Is in the part of the bug list where Steve works on if he isn't doing netplay or supply.

[Shannon V. OKeets]

ORIGINAL: Zartacla

Two CVP's were used for ground support and intercepted. During the air to air battle, one was aborted. The German fighter was also aborted, causing Germany to abort the fight rather than risk 2 bombers unescorted against a CW fighter that was escorting the CVP's. However, both CVP's added their factors as ground support, despite one of them aborting.

I have this fixed for version 1.1.3.0 - which should be available on Monday.

Keeping track of which units are aborted isn't easy since there are several ways to 'abort' a unit from a combat. In particular, the land based air units which voluntarily abort from an air-to-air combat get to remain in the sea area (still flying in the same section box). Land based air units aborted because of a DA or AA result in air-to-air combat or by an abort result due to anti-aircraft fire, immediately return to base (exiting the sea area, obviously).

The other oddity about 'aborting' units is that a naval unit could be aborting from a naval combat in one sea area, be intercepted in a second sea area, and be engaged in another naval combat. In that case, the naval unit is not aborting from the current combat but once the current combat is done, then it needs to continue to abort from its previous combat. That's why you may see both notations 'aborted' and 'aborting' in the Unit Data panel for a single unit. Aborted naval units remain in the sea area until the Naval Combat Abort digression at the end of a combat but are not eligible for participating in future combats in the sea area, nor can they receive any additional naval combat results.

The code is quite complex for all of this. When I needed to modify it to make it work for NetPlay, I had to improve the overall structure for this code fragment and messed up some of the finer details.