Bug with cult relation changes from policy decision

[Lockreed]

I've found a bug regarding relation with cults.

For all decisions that arise from the "discuss cult policy" stratagems, the relation for that cult does not change regardless of the decision. All of the other random event decisions appear to be working correctly for individual cult relation.

This behavior was confirmed with another player on discord by monitoring the REGKEY.cultx_relation value via the in-game debugger in table 146. (Thanks for your help, Magirot!)

It also appears that REGKEY.cultx_strength does not change as a result of random event decisions.

I dug into the S&S editor and found that REGKEY.cultx_relation gets assigned to <TEMP2>, <TEMP2> is then modified based on the selection, and then <TEMP2> is mapped back to REGKEY.cultx_relation in the 2nd "AFTER_DEC_ALL_LOGIC_SET" column (CZ in excel). Interestingly, this same column is used to map REGKEY.cultx_strength for random event cult decisions (also not working correctly).

As a test, I moved this assignment to "AFTER_DEC_ALL_LOGIC_SET" column CW. It still didn't work, so I checked the <TEMP2> value - lo and behold it had not changed after making a decision that should have changed it.

I then was able to create a mod that fixed this bug by moving all TEMP2 variable calculations (changes to cult relation) from "RESULT_IF_SET" (column BW) to "RESULT_SET". It appears TEMP2 was never actually getting adjusted, and just mapped back in to .cultx_relation, hence no change to cult relation.

According to S&S documentation, that column SHOULD have worked, but it didn't, so I'm assuming the bug is deeper than just something being in the wrong column

[Magirot]

According to S&S documentation, that column SHOULD have worked, but it didn't, so I'm assuming the bug is deeper than just something being in the wrong column

I realised I was looking at the wrong part: according to the documentation, After Decision Logic allows a blank logic check, but the Result Logic doesn't.






So the bug in the cult policy decisions might be caused by the RESULT_IF column being blank, and because of that RESULT_IF_SET never modifies TEMP2?


Forgetting the cause, screenshots that show the bug:


On turn start, my Eternity movement relation is 100.


I choose "Decrease policy in favor of Cult". Per columns 68 and 97, this should set relation to 80% of current relation.


However, as seen in Regime Keys, relation is unchanged. Only policy key has changed.