Incorrect #LINK= in German/Soviet Garrision Report

[DarkHorse2]

Consider the following scripts (from popup.txt)

1. These are probably misnamed as they just update the map symbols and do not present any report. I think I changed the name, locally, to German/Soviet Front Garrison Update Map Symbols 1941

2. The 1st script block has a dependent link to the The Molotov-Ribbentrop Pact? event. I believe this is wrong for the following reasons.
- There is nothing that changes the garrison requirements (see mobilization_1.txt) on rather the Molotov-Ribbentrop Pact is agreed to or not.
- If #LINK= 600[1] was appropriate, then it would be used in all 3 of the following script blocks.
- In fact, if the Molotov-Ribbentrop Pact is not agreed to, (i.e. #LINK= 600[1] fails), I suspected that the following will result in a mess.



;REMOVE1942
;
{
#NAME= ALLIED AI: German/Soviet Front Garrison Report 1941
#POPUP=
#MESSAGE= <<TAG_179>>
#IMAGE=
#SOUND=
#FLAG= 1
#TYPE= 2
#AI= 4
#LEVEL= 0
; Set global variable condition to always trigger (dummy value)
#GV= 1[1,100]
; Set link value to always trigger (dummy value
#LINK= 600[1]
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
; believe this should be changed to
; #LINK= 0[0]
#COUNTRY_ID= 45
#TRIGGER= 100
#PRIVATE= 1
#DISPLAY_ORDER= 1
#DISPLAY_TURN= 1
#DISPLAY_STYLE= 2.15
#MESSAGE_STYLE= 0
#TEXT_RGB= 0,0,0
#SHADOW_RGB= 0,0,0
#MAP_POSITION= 186,74
#MAP_POSITION= 189,66
#MAP_POSITION= 191,67
#MAP_POSITION= 193,68
#MAP_POSITION= 195,69
#MAP_POSITION= 197,70
#MAP_POSITION= 198,72
#MAP_POSITION= 198,74
#MAP_POSITION= 198,76
#MAP_POSITION= 198,78
#MAP_POSITION= 198,80
#MAP_POSITION= 197,81
#MAP_POSITION= 195,82
#MAP_POSITION= 193,83
#MAP_POSITION= 191,84
#MAP_POSITION= 189,85
#MAP_POSITION= 187,85
#MAP_POSITION= 185,84
#MAP_POSITION= 183,83
#MAP_POSITION= 181,82
#MAP_POSITION= 179,81
#MAP_POSITION= 178,80
#MAP_POSITION= 178,78
#MAP_POSITION= 178,76
#MAP_POSITION= 178,74
#MAP_POSITION= 178,72
#MAP_POSITION= 179,70
#MAP_POSITION= 181,69
#DATE= 1941/01/01
; Berlin is in Axis hands
#ALIGNMENT_POSITION= 173,74 [1]
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
; the previous should probably also be changed (here and the following blocks) to:
; Warsaw(188,76) is Axis
#ALIGNMENT_POSITION= 188,76 [1]

#VARIABLE_CONDITION= 116 [2] [0] [0]
#VARIABLE_CONDITION= 45 [1] [100] [0]
; Dummy Condition Position
#CONDITION_POSITION= 0,0 [0,0] [0,0] [0] [0]
}

;REMOVE1942
;
{
#NAME= ALLIED AI: German/Soviet Front Garrison Report 1941
#POPUP=
#MESSAGE= <<TAG_179>>
#IMAGE=
#SOUND=
#FLAG= 1
#TYPE= 2
#AI= 4
#LEVEL= 0
; Set global variable condition to always trigger (dummy value)
#GV= 1[1,100]
; Set link value to always trigger (dummy value)
#LINK= 0[0]
#COUNTRY_ID= 45
#TRIGGER= 100
#PRIVATE= 1
#DISPLAY_ORDER= 1
#DISPLAY_TURN= 1
#DISPLAY_STYLE= 2.14
#MESSAGE_STYLE= 0
#TEXT_RGB= 0,0,0
#SHADOW_RGB= 0,0,0
#MAP_POSITION= 186,74
#MAP_POSITION= 189,66
#MAP_POSITION= 191,67
#MAP_POSITION= 193,68
#MAP_POSITION= 195,69
#MAP_POSITION= 197,70
#MAP_POSITION= 198,72
#MAP_POSITION= 198,74
#MAP_POSITION= 198,76
#MAP_POSITION= 198,78
#MAP_POSITION= 198,80
#MAP_POSITION= 197,81
#MAP_POSITION= 195,82
#MAP_POSITION= 193,83
#MAP_POSITION= 191,84
#MAP_POSITION= 189,85
#MAP_POSITION= 187,85
#MAP_POSITION= 185,84
#MAP_POSITION= 183,83
#MAP_POSITION= 181,82
#MAP_POSITION= 179,81
#MAP_POSITION= 178,80
#MAP_POSITION= 178,78
#MAP_POSITION= 178,76
#MAP_POSITION= 178,74
#MAP_POSITION= 178,72
#MAP_POSITION= 179,70
#MAP_POSITION= 181,69
#DATE= 1941/01/01
; Berlin is in Axis hands
#ALIGNMENT_POSITION= 173,74 [1]
#VARIABLE_CONDITION= 116 [2] [0] [0]
#VARIABLE_CONDITION= 45 [1] [100] [0]
; Axis have less than 4 units within 10 hexes of Warsaw
#CONDITION_POSITION= 188,76 [10,10] [4,4] [1] [0] [<]
}

;REMOVE1941
;
{
#NAME= ALLIED AI: German/Soviet Front Garrison Report 1941 (more than 18 units)
#POPUP=
#MESSAGE= <<TAG_180>>
#IMAGE=
#SOUND=
#FLAG= 1
#TYPE= 2
#AI= 4
#LEVEL= 0
; Set global variable condition to always trigger (dummy value)
#GV= 1[1,100]
; Set link value to always trigger (dummy value)
#LINK= 0[0]
#COUNTRY_ID= 45
#TRIGGER= 100
#PRIVATE= 1
#DISPLAY_ORDER= 1
#DISPLAY_TURN= 1
#DISPLAY_STYLE= 2.14
#MESSAGE_STYLE= 0
#TEXT_RGB= 0,0,0
#SHADOW_RGB= 0,0,0
#MAP_POSITION= 186,74
#MAP_POSITION= 189,66
#MAP_POSITION= 191,67
#MAP_POSITION= 193,68
#MAP_POSITION= 195,69
#MAP_POSITION= 197,70
#MAP_POSITION= 198,72
#MAP_POSITION= 198,74
#MAP_POSITION= 198,76
#MAP_POSITION= 198,78
#MAP_POSITION= 198,80
#MAP_POSITION= 197,81
#MAP_POSITION= 195,82
#MAP_POSITION= 193,83
#MAP_POSITION= 191,84
#MAP_POSITION= 189,85
#MAP_POSITION= 187,85
#MAP_POSITION= 185,84
#MAP_POSITION= 183,83
#MAP_POSITION= 181,82
#MAP_POSITION= 179,81
#MAP_POSITION= 178,80
#MAP_POSITION= 178,78
#MAP_POSITION= 178,76
#MAP_POSITION= 178,74
#MAP_POSITION= 178,72
#MAP_POSITION= 179,70
#MAP_POSITION= 181,69
#DATE= 1941/01/01
; Berlin is in Axis hands
#ALIGNMENT_POSITION= 173,74 [1]
#VARIABLE_CONDITION= 116 [2] [0] [0]
#VARIABLE_CONDITION= 45 [1] [100] [0]
; Axis have more than 18 units within 10 hexes of Warsaw
#CONDITION_POSITION= 188,76 [10,10] [19,19] [1] [0]
}

[BillRunacre]

Thanks, I've made a note to take a look into this.