[1.25g] Building mining asset hangs game won't build

[Disturbance20]

We have multiple issues with this save. The easiest one to duplicate is attempting to build a metal mining asset at hex (79,31) will hang the game and never build it, ultimately requiring a shutdown of the application. I waited over 10 minutes to see if it would eventually complete and it did not.

The other issue we have is any strat card to recruit a new leader takes an very long time to complete, about 5-10 minutes. This is being reported by all 4 players.

The 4th and final player also reports turn ending timers are taking upwards towards 30 minutes to complete.

I have attached the latest save we have, which is sitting on turn 63 player 1. Happy to send older versions if needed, we have the mall saved in discord.

Thanks!

[Vic]

Quick check. There are 90.000 entries in the stringlist ID=178, first names masculine.
Same for other linguistics table.
I'll see if I can optimize code a bit for these huge lists.
Not sure these are unique names in there by the way.
best wishes,
Vic

[Vic]

Which did not make sense.

It seems the mod is being loaded many times... close to #of players * # of rounds played. Causing longer and longer delays as the stringlists grow and grow with redundant data.

investigating!

[Raagun]

Reporter did not mention we use Name list mod. This was expected culprit from comparing issue to other MP games.

Slowdown was noticed

• during hiring new leader

• creating new asset on empty hex (doesn't happen if hex already has assets)

• during AI turns

[Vic]

I dont understand yet how the data from the mod got re-added so many times to the core data tables.

Just to be sure... the waits got longer and longer as the game processed or it has been like this from the beginning?

[Raagun]

I dont understand yet how the data from the mod got re-added so many times to the core data tables.

Just to be sure... the waits got longer and longer as the game processed or it has been like this from the beginning?

100% sure it got worse over time. Or mostly it got bad at some point. Maybe where code just hit some performance ceiling.
During first 20-30 turn it was absolutely unnoticeable.

I am playing another MP game with this mod and we experiencing same slowdown. Hard to say when but only started to see issue about turn 40ish. I can run some tests. I have all the saves and am last player who runs AI turns.

[Raagun]

Here added two saves
T21 - building asset took ~14secs
T30 - building asset took ~27secs
But cant say that this is reproducible. I could be wrong.
Tried same experiment second time and times were wildly different.

[Disturbance20]

Yes I'm sorry Vic, I should have included all mods being used:

The naming mod is the culprit, we took this out and started a new game with all the other mods and it works fine.

In case it's an interaction between mods that's causing the issue, here are the other mods used:

Pymous Unit Mod
VAdjust

[Vic]

Hi,

Okay got everything figured out. The naming mod was not really the culprit actually, only indirectly, as there was a bug in the code causing it to malfunction.

Will have this fixed for the next open beta.

Big thanks for reporting this one, I consider it quite an oversight on my part. apologies.

best wishes,
Vic

[Raagun]

So I suspect the existing save file are corrupted forever? Beta fix will just prevent it happening again.

[Magirot]

Thanks for fixing it!

We tried some tests in PBEM yesterday/today and it indeed seemed to be happening in all mods that modified existing tables. I guess it was just lucky that most mods didn't add that many and/or didn't have noticeable conflicts.

[Disturbance20]

Thanks Vic! Always appreciated how often you actually read our bugs and/or suggestions and do it.

[Raagun]

So I just ran AI turn (cause I was last player in these games). And slow down is totally gone even on corrupted files.
New beta solved the issue fully!

Btw just want to say Vic, I love your game. I remember waiting for it to come out